juyung/devscard
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix work timeline item tag missing links (#108)

Browse source
This commit is contained in:
Szymon Kin 2022-12-03 18:49:46 +01:00 committed by GitHub
parent 9f08435fbf
commit a6c95f4046
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 16 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
src/components/organisms/work-timeline-item.astro
View file

@ -46,13 +46,21 @@ const WorkTimelineItem = 'div';
) )
} }
</ul> </ul>
<div class:list={['flex', 'gap-3', 'flex-wrap', 'sm:flex-nowrap', 'mt-3']}> <div class:list={['flex', 'gap-3', 'flex-wrap', 'mt-3']}>
{ {
job.tags.map((t) => ( job.tags.map(({ icon, iconColor, name, url }) => {
<Tag name={t.icon} color={t.iconColor}> return url ? (
{t.name} <a href={url} target="_blank" rel="noopener noreferrer">
</Tag> <Tag name={icon} color={iconColor}>
)) {name}
</Tag>
</a>
) : (
<Tag name={icon} color={iconColor}>
{name}
</Tag>
);
})
} }
</div> </div>
</WorkTimelineItem> </WorkTimelineItem>

4
src/types/icon.ts
View file

@ -1,3 +1,3 @@
import type { CircleFlags, Fa6Brands, Fa6Solid, SimpleIcons } from 'iconify-icon-names'; import type { CircleFlags, Fa6Brands, Fa6Solid, Logos, SimpleIcons } from 'iconify-icon-names';
export type IconName = Fa6Brands | Fa6Solid | SimpleIcons | CircleFlags; export type IconName = Fa6Brands | Fa6Solid | SimpleIcons | CircleFlags | Logos;